Bug 256157 – Pinch to zoom gesture in Google Maps and Figma is not working in OpenSource builds

• Status: REOPENED
• Component: Canvas

[Vladimir Prelovac]

Steps to reproduce:

- Build WebKit with 
- Run Mini browser
- Go to https://www.google.com/maps

Pinch to zoom in/out on a map will not work. The same is in Figma app (to zoom the canvas).

It works properly in Safari.

[Alexey Proskuryakov]

Not sure if this is a regression, or just a MiniBrowser issue.

[Radar WebKit Bug Importer]

<rdar://problem/108811433>

[Vladimir Prelovac]

(In reply to Radar WebKit Bug Importer from comment #2)
> <rdar://problem/108811433>

Thanks for looking into this.

It has been like this for at least 6 months. 

When I say mini browser I mean Webkit build. It also does not work when WebKit is used separately.

[Simon Fraser (smfr)]

I can’t reproduce; pinch zoom works in MiniBrowser for me.

[Vladimir Prelovac]

(In reply to Simon Fraser (smfr) from comment #4)
> I can’t reproduce; pinch zoom works in MiniBrowser for me.

Note that what happens is canvas zoom, not the map. In Safari if you pinch to zoom in, the map will actually change the zoom level allowing you to zoom into a location. In standalone WebKit these gestures do not get passed to the map, and standard WebKit pinch gesture is executed. Hope that makes sense.

[Simon Fraser (smfr)]

I see the map zoom. Check the User Agent setting in MiniBrowser?

[Vladimir Prelovac]

(In reply to Simon Fraser (smfr) from comment #6)
> I see the map zoom. Check the User Agent setting in MiniBrowser?

User Agent set  to default.

I made this video. This is WebKit just compiled off main branch, on Ventura. The map does not zoom, just the canvas does. 


https://streamable.com/z11tqi

[Vladimir Prelovac]

From poking around a little bit I found these relevant leads


https://bugs.webkit.org/show_bug.cgi?id=145214
https://bugs.webkit.org/show_bug.cgi?id=225788

https://trac.webkit.org/changeset/277772/webkit

#if ENABLE(MAC_GESTURE_EVENTS)

#if ENABLE(KINETIC_SCROLLING)

[Vladimir Prelovac]

I should note that two finger pinch to zoom (diagonal towards each other) does not work. In Safari this works normally (in WebKit causes canvas zoom).

https://c.tenor.com/R8Ic64GwH4EAAAAM/zoom-fingers.gif

Two fingers parallel does zoom in WebKit:

https://www.htc.com/media/filer_public/support/au/guid-32c58e9b-f3c1-4dc3-864e-1953b8893258-web_BxX5txz.gif

[Tim Horton]

This is expected, apologies!

[Vladimir Prelovac]

(In reply to Tim Horton from comment #10)
> This is expected, apologies!

Sorry, what is?

[Tim Horton]

(In reply to Vladimir Prelovac from comment #11)
> (In reply to Tim Horton from comment #10)
> > This is expected, apologies!
> 
> Sorry, what is?

The fact that gesture events don't work in local builds.

[Vladimir Prelovac]

Sorry, why wouldn't they work? This prevents usage in apps like Maps and Figma.

[Tim Horton]

(In reply to Vladimir Prelovac from comment #13)
> Sorry, why wouldn't they work? This prevents usage in apps like Maps and
> Figma.

To be clear, you're saying they don't work with built-in system WebKit (not custom-built WebKit) in Maps and Figma?

[Vladimir Prelovac]

(In reply to Tim Horton from comment #14)
> (In reply to Vladimir Prelovac from comment #13)
> > Sorry, why wouldn't they work? This prevents usage in apps like Maps and
> > Figma.
> 
> To be clear, you're saying they don't work with built-in system WebKit (not
> custom-built WebKit) in Maps and Figma?

No, I am saying gestures do not work in custom-built WebKit, but do work in Safari (haven't checked built-in system explicitly)

[Simon Fraser (smfr)]

To clarify, gesture events don’t work in open source builds. There’s a bit of Apple-internal code that’s necessary (and which I compiled with when testing).

[Vladimir Prelovac]

(In reply to Simon Fraser (smfr) from comment #16)
> To clarify, gesture events don’t work in open source builds. There’s a bit
> of Apple-internal code that’s necessary (and which I compiled with when
> testing).

Thanks for confirming. That is the reason I opened this issue. 

Sorry, I see you marked it as WONTFIX but have not given any explanation why the open-source build could not enable this?

[Vladimir Prelovac]

> There’s a bit
> of Apple-internal code that’s necessary (and which I compiled with when
> testing).

Can WebKit get access to this so that open source builds can enjoy gestures? It feels arbitrary to lock out such an important feature out of open-source builds.

[Berkay Ozturk]

I'm not a WebKit developer but as an end-user I wanted to say that the lack of access to gesture events on open source builds is a big problem for people like me. I am using the Orion browser and I'm not able to properly use web applications like Google Maps. I would love to understand why gesture events are excluded from open source builds.

[Simone Bianchin]

Yes please, this is a major issue for people that work with basic tools nowadays like Miro, Figma and everything that works with canvas. Please consider to fix

[Luigi]

Hi team, it would be great to have this in some roadmap eventually, :many-thanks!

[Adam]

+1 to fix this, this bug makes open source builds completely unusable on a daily basis. Such a basic function such as pinch-to-zoom is necessary as an OSX user - a large majority of sites now utilize that pinch-to-zoom functionality so not having it breaks the function of many many sites. Please fix this.

Just signed up to the Bugzilla to add my vote for fixing this. It's making a lot of highly interactive web apps basically unusable. :(

[Sam Behrens]

This is a very big issue for me and I would love to see it addressed in the Open Source WebKit Builds.

[Aaron]

Joining the crowd here in asking for this to be available for open source builds. It locks out critical functionality for us as users. Please add this!

[Aaron]

Joining the crowd here in asking for this to be available for open source builds. It locks out critical functionality for us as users. Please add this!

[Miguel Carneiro]

I have the same issue as others described below. I don't think more info is needed, but this seems to be a problem in sites such as:
- google maps
- figma
- and many others.

Please fix this as it seems to be fixed already in Safari.

Have an amazing week!

[Steve Alexander]

I'm having the same difficulty. I want to use the open source release of webkit for sites that use zoom gestures, such as Miro.

[Oskar]

The problem still persists on custom builds of WebKit

[[e-mail]]

The problem still exist and I really hope webkits can fix it! Happy New Year