Bug 256146 - Re-express some ARM64E emitters using a NUMBER_OF_ADDRESS_ENCODING_INSTRUCTIONS parameter in ARM64Assembler.
Summary: Re-express some ARM64E emitters using a NUMBER_OF_ADDRESS_ENCODING_INSTRUCTIO...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-30 01:36 PDT by Mark Lam
Modified: 2023-05-01 17:08 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2023-04-30 01:36:50 PDT
The only difference between the ARM64 and ARM64E versions of these emitters is due to the NUMBER_OF_ADDRESS_ENCODING_INSTRUCTIONS.  By making the ARM64 emitters aware of NUMBER_OF_ADDRESS_ENCODING_INSTRUCTIONS, we can remove the redundant code in ARM64EAssembler.
Comment 1 Radar WebKit Bug Importer 2023-04-30 01:37:14 PDT
<rdar://problem/108708885>
Comment 2 Mark Lam 2023-04-30 02:12:40 PDT
Pull request: https://github.com/WebKit/WebKit/pull/13314
Comment 3 EWS 2023-05-01 17:08:14 PDT
Committed 263563@main (87b83b04feed): <https://commits.webkit.org/263563@main>

Reviewed commits have been landed. Closing PR #13314 and removing active labels.