RESOLVED FIXED 25608
Unused m_frame in ChromiumClipboard.h 
https://bugs.webkit.org/show_bug.cgi?id=25608
Summary Unused m_frame in ChromiumClipboard.h
Julie Parent
Reported 2009-05-06 22:29:18 PDT
Never used, never set. Leads to lots of fun when you see it in the header and assume it is valid :)
Attachments
Patch removing m_frame (995 bytes, patch)
2009-05-06 22:35 PDT, Julie Parent 		fishd: review+
DetailsFormatted DiffDiff
New patch with ChangeLog properly filled in. (1.10 KB, patch)
2009-05-06 23:41 PDT, Julie Parent 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julie Parent
Comment 1 2009-05-06 22:35:14 PDT
Created attachment 30088 [details] Patch removing m_frame
Darin Fisher (:fishd, Google)
Comment 2 2009-05-06 22:47:32 PDT
Comment on attachment 30088 [details] Patch removing m_frame >+2009-05-06 jparent <set EMAIL_ADDRESS environment variable> please set REAL_NAME and EMAIL_ADDRESS environment variables next time so that prepare-ChangeLog works properly. >+ Reviewed by NOBODY (OOPS!). >+ >+ WARNING: NO TEST CASES ADDED OR CHANGED please delete this line, and replace it with a bug link and a description of the change.
Julie Parent
Comment 3 2009-05-06 23:41:30 PDT
Created attachment 30089 [details] New patch with ChangeLog properly filled in.
Eric Seidel (no email)
Comment 4 2009-05-06 23:44:05 PDT
Comment on attachment 30089 [details] New patch with ChangeLog properly filled in. Looks great.
Eric Seidel (no email)
Comment 5 2009-05-06 23:48:10 PDT
M WebCore/ChangeLog M WebCore/platform/chromium/ClipboardChromium.h Committed r43335
Note You need to log in before you can comment on or make changes to this bug.