Bug 25608 - Unused m_frame in ChromiumClipboard.h
Summary: Unused m_frame in ChromiumClipboard.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Julie Parent
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-06 22:29 PDT by Julie Parent
Modified: 2009-05-06 23:48 PDT (History)
1 user (show)

See Also:


Attachments
Patch removing m_frame (995 bytes, patch)
2009-05-06 22:35 PDT, Julie Parent
fishd: review+
Details | Formatted Diff | Diff
New patch with ChangeLog properly filled in. (1.10 KB, patch)
2009-05-06 23:41 PDT, Julie Parent
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Parent 2009-05-06 22:29:18 PDT
Never used, never set.  Leads to lots of fun when you see it in the header and assume it is valid :)
Comment 1 Julie Parent 2009-05-06 22:35:14 PDT
Created attachment 30088 [details]
Patch removing m_frame
Comment 2 Darin Fisher (:fishd, Google) 2009-05-06 22:47:32 PDT
Comment on attachment 30088 [details]
Patch removing m_frame

>+2009-05-06  jparent  <set EMAIL_ADDRESS environment variable>

please set REAL_NAME and EMAIL_ADDRESS environment variables next time so
that prepare-ChangeLog works properly.


>+        Reviewed by NOBODY (OOPS!).
>+
>+        WARNING: NO TEST CASES ADDED OR CHANGED

please delete this line, and replace it with a bug link and a description
of the change.
Comment 3 Julie Parent 2009-05-06 23:41:30 PDT
Created attachment 30089 [details]
New patch with ChangeLog properly filled in.
Comment 4 Eric Seidel (no email) 2009-05-06 23:44:05 PDT
Comment on attachment 30089 [details]
New patch with ChangeLog properly filled in.

Looks great.
Comment 5 Eric Seidel (no email) 2009-05-06 23:48:10 PDT
	M	WebCore/ChangeLog
	M	WebCore/platform/chromium/ClipboardChromium.h
Committed r43335