Bug 256077 – AX: Reduce unnecessary reliance on renderers in AccessibilityListBox, AccessibilitySlider, AccessibilityTableCell, AccessibilityTableRow, AccessibilityTable, and AccessibilityARIAGrid

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

This will make it easier to support display:contents for these classes.

[Radar WebKit Bug Importer]

<rdar://problem/108644964>

[Tyler Wilcock]

Created attachment 466121 [details]
Patch

[Tyler Wilcock]

Created attachment 466123 [details]
Patch

[chris fleizach]

Comment on attachment 466123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466123&action=review

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:336
> +    if (static_cast<int>(rowRange.second) == -1) {

how would this be -1 if the original declaration is unsigned?

std::pair<unsigned, unsigned> rowRange

[Tyler Wilcock]

(In reply to chris fleizach from comment #4)
> Comment on attachment 466123 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=466123&action=review
> 
> > Source/WebCore/accessibility/AccessibilityTableCell.cpp:336
> > +    if (static_cast<int>(rowRange.second) == -1) {
> 
> how would this be -1 if the original declaration is unsigned?
> 
> std::pair<unsigned, unsigned> rowRange
axRowSpan() will assign rowRange.second to -1, but since it's unsigned that will actually assign a value of 4294967295. But the check here does static_cast<int>, turning 4294967295 back into -1. So I think this should be OK

[chris fleizach]

(In reply to Tyler Wilcock from comment #5)
> (In reply to chris fleizach from comment #4)
> > Comment on attachment 466123 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=466123&action=review
> > 
> > > Source/WebCore/accessibility/AccessibilityTableCell.cpp:336
> > > +    if (static_cast<int>(rowRange.second) == -1) {
> > 
> > how would this be -1 if the original declaration is unsigned?
> > 
> > std::pair<unsigned, unsigned> rowRange
> axRowSpan() will assign rowRange.second to -1, but since it's unsigned that
> will actually assign a value of 4294967295. But the check here does
> static_cast<int>, turning 4294967295 back into -1. So I think this should be
> OK

Yea seems reasonable as long as overflow math continues to work

[EWS]

Committed 263511@main (3228c83a428f): <https://commits.webkit.org/263511@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466123 [details].