WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
256056
Move SleepDisabler ownership from WebProcessProxy to WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=256056
Summary
Move SleepDisabler ownership from WebProcessProxy to WebPageProxy
Chris Dumez
Reported
2023-04-27 13:15:34 PDT
Move SleepDisabler ownership from WebProcessProxy to WebPageProxy. Those "sleep disabling" assertion are taken by paging and it thus makes sense for their lifetime to be tired to the page rather than the process. This tighter scoping reduces the chances of assertion leakage and fit nicely with our UIProcess-side logic now that we rely on the UIClient to take some of these assertions.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2023-04-27 13:24:44 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/13245
EWS
Comment 2
2023-04-27 17:15:17 PDT
Committed
263474@main
(9bfa2b8cde5b): <
https://commits.webkit.org/263474@main
> Reviewed commits have been landed. Closing PR #13245 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-04-27 17:16:22 PDT
<
rdar://problem/108635306
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug