Bug 256056 - Move SleepDisabler ownership from WebProcessProxy to WebPageProxy
Summary: Move SleepDisabler ownership from WebProcessProxy to WebPageProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-27 13:15 PDT by Chris Dumez
Modified: 2023-04-28 11:18 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-04-27 13:15:34 PDT 
Move SleepDisabler ownership from WebProcessProxy to WebPageProxy. Those "sleep disabling" assertion are taken by paging and it thus makes sense for their lifetime to be tired to the page rather than the process. This tighter scoping reduces the chances of assertion leakage and fit nicely with our UIProcess-side logic now that we rely on the UIClient to take some of these assertions.
Comment 1 Chris Dumez 2023-04-27 13:24:44 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13245
Comment 2 EWS 2023-04-27 17:15:17 PDT 
Committed 263474@main (9bfa2b8cde5b): <https://commits.webkit.org/263474@main>

Reviewed commits have been landed. Closing PR #13245 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-04-27 17:16:22 PDT 
<rdar://problem/108635306>