RESOLVED FIXED 255993
Improve support for gradient in post-processed ImageData 
https://bugs.webkit.org/show_bug.cgi?id=255993
Summary Improve support for gradient in post-processed ImageData
Matthew Finkel
Reported 2023-04-26 10:32:59 PDT
Improve support for gradient in post-processed ImageData
Attachments
Add attachment proposed patch, testcase, etc.
Matthew Finkel
Comment 1 2023-04-26 10:33:03 PDT
rdar://107371244
Matthew Finkel
Comment 2 2023-04-26 10:38:26 PDT
Pull request: https://github.com/WebKit/WebKit/pull/13199
EWS
Comment 3 2023-05-11 12:13:13 PDT
Committed 263979@main (eabcb3ec87c6): <https://commits.webkit.org/263979@main> Reviewed commits have been landed. Closing PR #13199 and removing active labels.
Chris Dumez
Comment 4 2023-05-11 15:40:48 PDT
I suspect this broke photo editing on https://photos.google.com: ``` Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x1888421fc __pthread_kill + 8 1 libsystem_pthread.dylib 0x188879cc0 pthread_kill + 288 2 libsystem_c.dylib 0x188789a98 abort + 180 3 libc++.1.dylib 0x1887b4174 std::__1::__libcpp_verbose_abort(char const*, ...) + 92 4 WebCore 0x111fabbcc std::__1::optional<unsigned long long>::operator*[abi:v160002]() && + 48 (optional:971) [inlined] 5 WebCore 0x111fabbcc WebCore::CanvasBase::makeRenderingResultsAvailable() + 336 (CanvasBase.cpp:112) 6 WebCore 0x111fde164 WebCore::HTMLCanvasElement::toDataURL(WTF::String const&, JSC::JSValue) + 464 (HTMLCanvasElement.cpp:733) 7 WebCore 0x111107520 WebCore::jsHTMLCanvasElementPrototypeFunction_toDataURLBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSHTMLCanvasElement*) + 216 ```
Chris Dumez
Comment 5 2023-05-11 15:47:06 PDT
(In reply to Chris Dumez from comment #4) > I suspect this broke photo editing on https://photos.google.com: > ``` > Thread 0 Crashed:: Dispatch queue: com.apple.main-thread > 0 libsystem_kernel.dylib 0x1888421fc __pthread_kill + 8 > 1 libsystem_pthread.dylib 0x188879cc0 pthread_kill + 288 > 2 libsystem_c.dylib 0x188789a98 abort + 180 > 3 libc++.1.dylib 0x1887b4174 > std::__1::__libcpp_verbose_abort(char const*, ...) + 92 > 4 WebCore 0x111fabbcc > std::__1::optional<unsigned long long>::operator*[abi:v160002]() && + 48 > (optional:971) [inlined] > 5 WebCore 0x111fabbcc > WebCore::CanvasBase::makeRenderingResultsAvailable() + 336 > (CanvasBase.cpp:112) > 6 WebCore 0x111fde164 > WebCore::HTMLCanvasElement::toDataURL(WTF::String const&, JSC::JSValue) + > 464 (HTMLCanvasElement.cpp:733) > 7 WebCore 0x111107520 > WebCore::jsHTMLCanvasElementPrototypeFunction_toDataURLBody(JSC:: > JSGlobalObject*, JSC::CallFrame*, WebCore::JSHTMLCanvasElement*) + 216 > ``` Filed rdar://109232285.
Matthew Finkel
Comment 6 2023-05-11 16:09:36 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/13779
EWS
Comment 7 2023-05-12 10:39:36 PDT
Committed 264019@main (bfc25dc6ca1c): <https://commits.webkit.org/264019@main> Reviewed commits have been landed. Closing PR #13791 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.