Bug 255993 - Improve support for gradient in post-processed ImageData
Summary: Improve support for gradient in post-processed ImageData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matthew Finkel
URL:
Keywords: InRadar
Depends on: 256677
Blocks:
  Show dependency tree / graph
 
Reported: 2023-04-26 10:32 PDT by Matthew Finkel
Modified: 2023-05-12 10:39 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Finkel 2023-04-26 10:32:59 PDT 
Improve support for gradient in post-processed ImageData
Comment 1 Matthew Finkel 2023-04-26 10:33:03 PDT 
rdar://107371244
Comment 2 Matthew Finkel 2023-04-26 10:38:26 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13199
Comment 3 EWS 2023-05-11 12:13:13 PDT 
Committed 263979@main (eabcb3ec87c6): <https://commits.webkit.org/263979@main>

Reviewed commits have been landed. Closing PR #13199 and removing active labels.
Comment 4 Chris Dumez 2023-05-11 15:40:48 PDT 
I suspect this broke photo editing on https://photos.google.com:
```
Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	       0x1888421fc __pthread_kill + 8
1   libsystem_pthread.dylib       	       0x188879cc0 pthread_kill + 288
2   libsystem_c.dylib             	       0x188789a98 abort + 180
3   libc++.1.dylib                	       0x1887b4174 std::__1::__libcpp_verbose_abort(char const*, ...) + 92
4   WebCore                       	       0x111fabbcc std::__1::optional<unsigned long long>::operator*[abi:v160002]() && + 48 (optional:971) [inlined]
5   WebCore                       	       0x111fabbcc WebCore::CanvasBase::makeRenderingResultsAvailable() + 336 (CanvasBase.cpp:112)
6   WebCore                       	       0x111fde164 WebCore::HTMLCanvasElement::toDataURL(WTF::String const&, JSC::JSValue) + 464 (HTMLCanvasElement.cpp:733)
7   WebCore                       	       0x111107520 WebCore::jsHTMLCanvasElementPrototypeFunction_toDataURLBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSHTMLCanvasElement*) + 216 
```
Comment 5 Chris Dumez 2023-05-11 15:47:06 PDT 
(In reply to Chris Dumez from comment #4)
> I suspect this broke photo editing on https://photos.google.com:
> ```
> Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
> 0   libsystem_kernel.dylib        	       0x1888421fc __pthread_kill + 8
> 1   libsystem_pthread.dylib       	       0x188879cc0 pthread_kill + 288
> 2   libsystem_c.dylib             	       0x188789a98 abort + 180
> 3   libc++.1.dylib                	       0x1887b4174
> std::__1::__libcpp_verbose_abort(char const*, ...) + 92
> 4   WebCore                       	       0x111fabbcc
> std::__1::optional<unsigned long long>::operator*[abi:v160002]() && + 48
> (optional:971) [inlined]
> 5   WebCore                       	       0x111fabbcc
> WebCore::CanvasBase::makeRenderingResultsAvailable() + 336
> (CanvasBase.cpp:112)
> 6   WebCore                       	       0x111fde164
> WebCore::HTMLCanvasElement::toDataURL(WTF::String const&, JSC::JSValue) +
> 464 (HTMLCanvasElement.cpp:733)
> 7   WebCore                       	       0x111107520
> WebCore::jsHTMLCanvasElementPrototypeFunction_toDataURLBody(JSC::
> JSGlobalObject*, JSC::CallFrame*, WebCore::JSHTMLCanvasElement*) + 216 
> ```

Filed rdar://109232285.
Comment 6 Matthew Finkel 2023-05-11 16:09:36 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/13779
Comment 7 EWS 2023-05-12 10:39:36 PDT 
Committed 264019@main (bfc25dc6ca1c): <https://commits.webkit.org/264019@main>

Reviewed commits have been landed. Closing PR #13791 and removing active labels.