Bug 255954 - Use WKDataTask for SystemPreview downloads
Summary: Use WKDataTask for SystemPreview downloads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-25 14:45 PDT by Dean Jackson
Modified: 2023-04-25 22:57 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2023-04-25 14:45:04 PDT 
Migrate away from LegacyDownloadClient and instead handle System Previews directly. This will allow us to remove the horrible code in the download client, as well eventually allow 3rd-party engines to use ARQL.
Comment 1 Dean Jackson 2023-04-25 14:45:20 PDT 
<rdar://problem/108524222>
Comment 2 Dean Jackson 2023-04-25 14:53:28 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13171
Comment 3 EWS 2023-04-25 16:29:38 PDT 
Committed 263393@main (d55e3cae6649): <https://commits.webkit.org/263393@main>

Reviewed commits have been landed. Closing PR #13171 and removing active labels.
Comment 4 Ryosuke Niwa 2023-04-25 22:44:42 PDT 
This patch seems to have broken Apple internal builds.
Comment 5 Ryosuke Niwa 2023-04-25 22:57:36 PDT 
Build fix attempted in https://commits.webkit.org/263403@main