Bug 25593 - Refactor MediaPlayerPviate for Chromium port
Summary: Refactor MediaPlayerPviate for Chromium port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Hin-Chung Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-06 12:36 PDT by Hin-Chung Lam
Modified: 2009-05-06 12:58 PDT (History)
2 users (show)

See Also:


Attachments
patch + changelog (2.63 KB, patch)
2009-05-06 12:40 PDT, Hin-Chung Lam
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hin-Chung Lam 2009-05-06 12:36:43 PDT
Remove all the methods from MediaPlayerPrivate from MediaPlayerPrivateChromium.h so it only has one static method.
Comment 1 Hin-Chung Lam 2009-05-06 12:40:23 PDT
Created attachment 30059 [details]
patch + changelog

This is a refactoring, no layout tests are provided.
Comment 2 Darin Fisher (:fishd, Google) 2009-05-06 12:46:03 PDT
Comment on attachment 30059 [details]
patch + changelog

>+2009-05-06  hclam  <hclam@chromium.org>

actually, one nit for next time:  please set REAL_NAME in your environment so that prepare-ChangeLog automatically includes your full name instead of "hclam" in the ChangeLog.
Comment 3 Darin Fisher (:fishd, Google) 2009-05-06 12:58:27 PDT
Landed as:  http://trac.webkit.org/changeset/43321