WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
255928
Simplify / optimize JSC's LiteralParser
https://bugs.webkit.org/show_bug.cgi?id=255928
Summary
Simplify / optimize JSC's LiteralParser
Chris Dumez
Reported
2023-04-25 08:50:04 PDT
Simplify / optimize JSC's LiteralParser: - Avoid storing the start/end pointers inside LiteralParserToken, as they are not actually needed. We already have a `stringStart + length` for strings/identifiers, which is all that's needed. - Stop using LiteralParserToken::stringIs8Bit for identifiers. Unlike strings, identifiers always use the same character type as the LiteralParser. This also avoids some unnecessary branching.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2023-04-25 08:52:57 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/13151
EWS
Comment 2
2023-04-26 08:56:22 PDT
Committed
263416@main
(f6ec77d6554e): <
https://commits.webkit.org/263416@main
> Reviewed commits have been landed. Closing PR #13151 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-04-26 08:57:21 PDT
<
rdar://problem/108559160
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug