Bug 255921 - Remove Mode::Rfc2045 from ParsedContentType
Summary: Remove Mode::Rfc2045 from ParsedContentType
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 260605
Blocks: 255922
  Show dependency tree / graph
 
Reported: 2023-04-25 07:14 PDT by Anne van Kesteren
Modified: 2023-08-23 02:30 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2023-04-25 07:14:14 PDT 
It seems this was introduced in https://github.com/WebKit/WebKit/commit/e1790e8fee7cebd82248bfbfd735927895b48fab but it's not clear there's a good reason to keep Source/WebCore/platform/encryptedmedia/CDMPrivate.cpp on it.

Rob, Frédéric, if there was a strong reason you did things this way, please let me know.
Comment 1 Rob Buis 2023-04-25 07:26:26 PDT 
(In reply to Anne van Kesteren from comment #0)
> It seems this was introduced in
> https://github.com/WebKit/WebKit/commit/
> e1790e8fee7cebd82248bfbfd735927895b48fab but it's not clear there's a good
> reason to keep Source/WebCore/platform/encryptedmedia/CDMPrivate.cpp on it.
> 
> Rob, Frédéric, if there was a strong reason you did things this way, please
> let me know.

IRC that patch just introduced mimesniff mode and left Mode::Rfc2045 usage as before. I do not know encryptedmedia code at all so I can't judge that one, but maybe it is specced somewhere.
Comment 2 Radar WebKit Bug Importer 2023-05-02 07:15:19 PDT 
<rdar://problem/108787747>