Bug 25587 - [Qt] Fix Qt build when ENABLE_DATABASE is turned off
Summary: [Qt] Fix Qt build when ENABLE_DATABASE is turned off
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-06 09:10 PDT by Laszlo Gombos
Modified: 2009-05-11 09:23 PDT (History)
0 users

See Also:


Attachments
Fix Qt build when ENABLE_DATABASE is turned off (4.55 KB, patch)
2009-05-06 09:19 PDT, Laszlo Gombos
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-05-06 09:10:27 PDT
This will ensure that the Qt build compiles all the way when ENABLE_DATABASE is turned off.

This is a follow-up to some recent commits in this area:
 - http://trac.webkit.org/changeset/43283
 - http://trac.webkit.org/changeset/43285
Comment 1 Laszlo Gombos 2009-05-06 09:19:41 PDT
Created attachment 30052 [details]
Fix Qt build when ENABLE_DATABASE is turned off
Comment 2 Holger Freyther 2009-05-11 03:37:35 PDT
Patch looks good, I wonder how smart the compilers used are if you throw them a stub implementation in front of them... I would like to minimize the amount of #ifdef...
Comment 3 Holger Freyther 2009-05-11 09:23:40 PDT
Landed in r43496.