Bug 255758 – AX: Play Animation and Pause Animation actions don't appear for animations with a link parent element

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Tyler Wilcock]

Example demonstrating this:

<a href="#foo">
    <img src="animated-red-green-blue-repeat-infinite.gif" width="223" height="223" alt="Alt text">
</a>

[Radar WebKit Bug Importer]

<rdar://problem/108350118>

[Tyler Wilcock]

Created attachment 466022 [details]
Patch

[Tyler Wilcock]

Created attachment 466025 [details]
Patch

[Tyler Wilcock]

Created attachment 466026 [details]
Patch

[chris fleizach]

Comment on attachment 466026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466026&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:545
> +                [actions addObject:[_WKElementAction _elementActionWithType:_WKElementActionPauseAnimation info:elementInfo assistant:self]];

can we write these 4 lines as

[actions addObject:[_WKElementAction _elementActionWithType:elementInfo.isAnimating ? _WKElementActionPauseAnimation : _WKElementActionPlayAnimation  info:elementInfo assistant:self]];

> Tools/TestWebKitAPI/Tests/ios/ActionSheetTests.mm:379
> +#if ENABLE(ACCESSIBILITY_ANIMATION_CONTROL)

does this function need to be guarded by animation control? seems generic

[Tyler Wilcock]

Created attachment 466037 [details]
Patch

[Tyler Wilcock]

(In reply to chris fleizach from comment #5)
> Comment on attachment 466026 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=466026&action=review
> 
> > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:545
> > +                [actions addObject:[_WKElementAction _elementActionWithType:_WKElementActionPauseAnimation info:elementInfo assistant:self]];
> 
> can we write these 4 lines as
> 
> [actions addObject:[_WKElementAction
> _elementActionWithType:elementInfo.isAnimating ?
> _WKElementActionPauseAnimation : _WKElementActionPlayAnimation 
> info:elementInfo assistant:self]];
Yeah, that's nicer, thanks. Fixed in latest patch.

> > Tools/TestWebKitAPI/Tests/ios/ActionSheetTests.mm:379
> > +#if ENABLE(ACCESSIBILITY_ANIMATION_CONTROL)
> 
> does this function need to be guarded by animation control? seems generic
Since it's only used with ENABLE(ACCESSIBILITY_ANIMATION_CONTROL), I believe un-guarding it would cause an unused static function warning for other platforms.

[EWS]

Committed 263323@main (9a8207739bc9): <https://commits.webkit.org/263323@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466037 [details].