Bug 255736 – [margin-trim][block layout] self-collapsing children at block-end don't have nested content trimmed

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Sammy Gill]

If you have a block structure that is something similar to the following:

<container>
    <item style="margin-bottom: 10px"></item>
    <item style="margin-bottom: 10px; height: 0px;">
        <item style="margin-bottom: 10px; height: 0px;">
            <item style="margin-bottom: 10px; height: 0px;">
                <item style="margin-bottom: 10px; height: 0px;"></item>
                <item style="margin-bottom: 10px; height: 0px;"></item>
            </item>
        </item>
    </item>
</container>

We currently trim the last child, which is self collapsing, and its margins correctly, but none of the children nested within it are trimmed. Since these are at the block-end and we trim  the margins that are collapsed through for the container, none of the inner margins end up participating in margin collapsing with the container's margin and renderings look correct. However, with the tests added as a part of 253610 we can actually see that these margins are not trimmed by looking at the computed style values.

[Radar WebKit Bug Importer]

<rdar://problem/108327029>

[Sammy Gill]

Pull request: https://github.com/WebKit/WebKit/pull/12982

[Sammy Gill]

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/39674

[EWS]

Committed 263439@main (809b95bb1a78): <https://commits.webkit.org/263439@main>

Reviewed commits have been landed. Closing PR #12982 and removing active labels.