Bug 25569 - make ParserRefCounted use conventional reference counting
Summary: make ParserRefCounted use conventional reference counting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-05 09:58 PDT by Darin Adler
Modified: 2009-05-05 16:50 PDT (History)
0 users

See Also:


Attachments
patch (10.06 KB, patch)
2009-05-05 11:10 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
Sunspider results with this patch (3.43 KB, text/plain)
2009-05-05 13:44 PDT, Brady Eidson
no flags Details
patch (11.92 KB, patch)
2009-05-05 15:01 PDT, Darin Adler
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2009-05-05 09:58:51 PDT
Maciej suggests that we use a conventional reference counting scheme for parser nodes now that they are no longer kept around after compilation. This should give us a modest speedup.
Comment 1 Darin Adler 2009-05-05 11:10:13 PDT
Created attachment 30026 [details]
patch

Can't measure a speedup yet.
Comment 2 Brady Eidson 2009-05-05 13:44:59 PDT
Created attachment 30033 [details]
Sunspider results with this patch

Sunspider compare with this patch.  1.6% speedup overall.  Small slowdown noise on 4 tests.
Comment 3 Darin Adler 2009-05-05 15:01:17 PDT
Created attachment 30035 [details]
patch
Comment 4 Darin Adler 2009-05-05 16:50:57 PDT
http://trac.webkit.org/changeset/43259