WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
255688
Remove the abandoned 'LoadSiteIconsIgnoringImageLoadingPreference' setting
https://bugs.webkit.org/show_bug.cgi?id=255688
Summary
Remove the abandoned 'LoadSiteIconsIgnoringImageLoadingPreference' setting
Brent Fulgham
Reported
2023-04-19 16:15:19 PDT
The LoadSiteIconsIgnoringImageLoadingPreference is not used any longer, and we should remove it.
Attachments
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2023-04-19 16:17:47 PDT
<
rdar://107159912
>
Brent Fulgham
Comment 2
2023-04-19 16:20:41 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/12944
EWS
Comment 3
2023-04-20 15:21:40 PDT
Committed
263202@main
(4967181732a9): <
https://commits.webkit.org/263202@main
> Reviewed commits have been landed. Closing PR #12944 and removing active labels.
Adrian Perez
Comment 4
2023-04-24 13:26:21 PDT
Reopening to land a quick follow-up to
263202@main
to write an appropriate version in the “Deprecated:” tags. Brent, thanks for making the change in the API for the WPE/GTK ports :)
Brent Fulgham
Comment 5
2023-04-24 13:30:43 PDT
(In reply to Adrian Perez from
comment #4
)
> Reopening to land a quick follow-up to
263202@main
to write an > appropriate version in the “Deprecated:” tags. > > Brent, thanks for making the change in the API for the WPE/GTK ports :)
Sorry I couldn't give a good 'Deprecated' message; thank you for completing the task :-)
Adrian Perez
Comment 6
2023-04-24 13:32:08 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/13113
Adrian Perez
Comment 7
2023-04-24 13:33:44 PDT
(In reply to Brent Fulgham from
comment #5
)
> (In reply to Adrian Perez from
comment #4
) > > Reopening to land a quick follow-up to
263202@main
to write an > > appropriate version in the “Deprecated:” tags. > > > > Brent, thanks for making the change in the API for the WPE/GTK ports :) > > Sorry I couldn't give a good 'Deprecated' message; thank you for completing > the task :-)
No problem at all! =)
EWS
Comment 8
2023-04-24 15:43:42 PDT
Committed
263342@main
(c1e563b2e2ec): <
https://commits.webkit.org/263342@main
> Reviewed commits have been landed. Closing PR #13113 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug