Bug 25568 – Add ASSERT(useTransforms) to mapLocalToContainer and fix patterns on transformed text

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Eric Seidel (no email)]

Add ASSERT(useTransforms) to mapLocalToContainer and fix patterns on transformed text

This is the last patch attached to https://bugs.webkit.org/show_bug.cgi?id=25532 which got landed, and then rolled out, and now is ready for landing again.

[Eric Seidel (no email)]

Created attachment 30018 [details]
Add back ASSERT(useTransforms)

 7 files changed, 130 insertions(+), 19 deletions(-)

[Eric Seidel (no email)]

I'll add the expected results when I land.  Since the important part is the pixel tests, they're of little use to the reviewer and just make the patch larger.

[Simon Fraser (smfr)]

Comment on attachment 30018 [details]
Add back ASSERT(useTransforms)

r=me

Would prefer we replace the isPaintingText bool with an enum to make the code more readable at the call site (even though it wasn't added in this patch).

[Eric Seidel (no email)]

(In reply to comment #3)
> (From update of attachment 30018 [details] [review])
> r=me
> 
> Would prefer we replace the isPaintingText bool with an enum to make the code
> more readable at the call site (even though it wasn't added in this patch).

Thank you.  I think the enum change is for another patch though.  We're almost to the point where we don't even need it for this function!

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.checksum
	M	LayoutTests/platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png
	A	LayoutTests/platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum
	A	LayoutTests/platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png
	A	LayoutTests/platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt
	A	LayoutTests/platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum
	A	LayoutTests/platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png
	A	LayoutTests/platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt
	A	LayoutTests/svg/transforms/text-with-pattern-inside-transformed-html.xhtml
	A	LayoutTests/svg/transforms/text-with-pattern-with-svg-transform.svg
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderSVGRoot.cpp
	M	WebCore/rendering/SVGRenderSupport.cpp
	M	WebCore/svg/graphics/SVGPaintServerPattern.cpp
Committed r43269