Bug 255632 - Replace calls to InputType::formControlType() with InputType::type() whenever possible
Summary: Replace calls to InputType::formControlType() with InputType::type() whenever...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-18 16:49 PDT by Chris Dumez
Modified: 2023-04-18 18:10 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-04-18 16:49:13 PDT
Replace calls to InputType::formControlType() with InputType::type() whenever possible, since formControlType() is virtual.
`formControlType()` returns an AtomString representing the input type, while type()` returns the same thing as an enum value.
Comment 1 Chris Dumez 2023-04-18 16:51:49 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12893
Comment 2 EWS 2023-04-18 18:09:07 PDT
Committed 263110@main (4dce328fc705): <https://commits.webkit.org/263110@main>

Reviewed commits have been landed. Closing PR #12893 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-04-18 18:10:22 PDT
<rdar://problem/108235090>