Bug 25554 - Implement HTML5 Input element types for Text Fields
: Implement HTML5 Input element types for Text Fields
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Forms
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To: Nobody
: InRadar
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-04 14:49 PDT by Greg Bolsinga
Modified: 2009-05-05 18:15 PDT (History)
1 user (show)

See Also:


Attachments
add support for HTML text control input types (9.28 KB, patch)
2009-05-04 15:14 PDT, Greg Bolsinga
no flags Details | Formatted Diff | Diff
updated patch to fix DOMHTML.mm (10.77 KB, patch)
2009-05-04 16:29 PDT, Greg Bolsinga
eric: review-
Details | Formatted Diff | Diff
Now with working code and layout tests (13.86 KB, patch)
2009-05-04 19:47 PDT, Greg Bolsinga
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Bolsinga 2009-05-04 14:49:18 PDT
See http://dev.w3.org/html5/spec/Overview.html#attr-input-type

This bug report is just for the type keywords when "Control type" is Text Field.

tel, url, email, number are the ones not yet in WebCore.

<rdar://problem/5327885>
Comment 1 Greg Bolsinga 2009-05-04 15:14:53 PDT
Created attachment 29996 [details]
add support for HTML text control input types
Comment 2 Greg Bolsinga 2009-05-04 16:29:44 PDT
Created attachment 30001 [details]
updated patch to fix DOMHTML.mm
Comment 3 Eric Seidel 2009-05-04 17:16:08 PDT
Comment on attachment 30001 [details]
updated patch to fix DOMHTML.mm

Per IRC, r- for lack of test.
Comment 4 Greg Bolsinga 2009-05-04 19:47:22 PDT
Created attachment 30008 [details]
Now with working code and layout tests
Comment 5 Greg Bolsinga 2009-05-05 17:58:24 PDT
Fixed in r43267
Comment 6 Greg Bolsinga 2009-05-05 18:15:34 PDT
http://trac.webkit.org/changeset/43267