Bug 255480 – AX: isSelected AX APIs don't work for some types of display:contents elements

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

That's because `isSelected` is implemented for AccessibilityRenderObject and not AccessibilityNodeObject despite the fact that the method does not actually require a renderer.

[Radar WebKit Bug Importer]

<rdar://problem/108083208>

[Tyler Wilcock]

Created attachment 465937 [details]
Patch

[chris fleizach]

Comment on attachment 465937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465937&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2767
> +    if (!renderer() && !node())

Should we proceed even if we don't have a renderer? for display contents. won't that not have a renderer

[Tyler Wilcock]

(In reply to chris fleizach from comment #3)
> Comment on attachment 465937 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=465937&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:2767
> > +    if (!renderer() && !node())
> 
> Should we proceed even if we don't have a renderer? for display contents.
> won't that not have a renderer
True that display:contents won't have a renderer(), but it will have a node(), so we should be OK here.

[chris fleizach]

Comment on attachment 465937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465937&action=review

>>> Source/WebCore/accessibility/AccessibilityObject.cpp:2767
>>> +    if (!renderer() && !node())
>> 
>> Should we proceed even if we don't have a renderer? for display contents. won't that not have a renderer
> 
> True that display:contents won't have a renderer(), but it will have a node(), so we should be OK here.

do we need to check renderer() then?

[Tyler Wilcock]

(In reply to chris fleizach from comment #5)
> Comment on attachment 465937 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=465937&action=review
> 
> >>> Source/WebCore/accessibility/AccessibilityObject.cpp:2767
> >>> +    if (!renderer() && !node())
> >> 
> >> Should we proceed even if we don't have a renderer? for display contents. won't that not have a renderer
> > 
> > True that display:contents won't have a renderer(), but it will have a node(), so we should be OK here.
> 
> do we need to check renderer() then?
Maybe not – I mostly tried to preserve the existing logic that would say "is selected" is false if there is no renderer. But I adapted it to display:contents to instead now be "is selected" is false if there is both no renderer and no node. Having one or the other satisfies the check and allows the function to proceed.

[EWS]

Committed 263014@main (0b61863f7ec7): <https://commits.webkit.org/263014@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465937 [details].