Bug 255447 - ResolutionMediaFeatureEnabled is a no-op
Summary: ResolutionMediaFeatureEnabled is a no-op
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari 16
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-14 03:55 PDT by Sam Sneddon [:gsnedders]
Modified: 2023-04-28 15:17 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2023-04-14 03:55:18 PDT
Since bug 248619 removed the (already dead) legacy media queries code, the ResolutionMediaFeatureEnabled setting has had no references within WebKit.

While dropping this setting is probably fine, we shouldn't have the setting hang around while it does nothing.
Comment 1 Tim Nguyen (:ntim) 2023-04-14 21:56:29 PDT
I wonder if we should reinstate this pref, I assume it was added to prevent fingerprinting. Though a better approach to prevent fingerprinting is to spoof this + other relevant vectors to 1x.
Comment 2 Sam Sneddon [:gsnedders] 2023-04-15 03:58:20 PDT
(In reply to Tim Nguyen (:ntim) from comment #1)
> I wonder if we should reinstate this pref, I assume it was added to prevent
> fingerprinting. Though a better approach to prevent fingerprinting is to
> spoof this + other relevant vectors to 1x.

No, it was added because it provided a path to enabling it in WebKit (versus the ~decade it had been behind a compile-time flag) and because we for a while had quirks that disabled it.
Comment 3 Radar WebKit Bug Importer 2023-04-21 03:56:17 PDT
<rdar://problem/108363296>
Comment 4 Tim Nguyen (:ntim) 2023-04-28 11:40:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/13281
Comment 5 EWS 2023-04-28 15:17:34 PDT
Committed 263519@main (2d54e17cd623): <https://commits.webkit.org/263519@main>

Reviewed commits have been landed. Closing PR #13281 and removing active labels.