RESOLVED FIXED 255440
Remove finishCreation()s that only call its superclass' finishCreation(). 
https://bugs.webkit.org/show_bug.cgi?id=255440
Summary Remove finishCreation()s that only call its superclass' finishCreation().
Mark Lam
Reported 2023-04-13 23:04:25 PDT
Introduce a DECLARE_DEFAULT_FINISH_CREATION macro to define finishCreation() when ASSERT_ENABLED, and to use Base::finishCreation when not ASSERT_ENABLED. Change code in JSC to use DECLARE_DEFAULT_FINISH_CREATION when finishCreation() is trivial i.e. effectively just calls the superclass version. Also change CodeGeneratorJS.pm to do that same.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-04-13 23:04:48 PDT
<rdar://problem/108034039>
Mark Lam
Comment 2 2023-04-13 23:15:04 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12732
EWS
Comment 3 2023-04-14 12:23:54 PDT
Committed 262983@main (7dbeef1bd19f): <https://commits.webkit.org/262983@main> Reviewed commits have been landed. Closing PR #12732 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.