Bug 255348 - [PlayStation][CFI] Remove unnecessary cast in FrameTree.cpp
Summary: [PlayStation][CFI] Remove unnecessary cast in FrameTree.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephan Szabo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-12 10:10 PDT by Stephan Szabo
Modified: 2023-04-12 11:54 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2023-04-12 10:10:08 PDT 
CFI builds on PlayStation failed when a LocalFrame was made and then the Frame construction made the FrameTree because that was trying to cast what was effectively *this to LocalFrame, but that wasn't yet a LocalFrame so was picked up as a bad derived cast. As the value was only being used there to stick into a Frame&, remove the cast.
Comment 1 Stephan Szabo 2023-04-12 10:43:53 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12659
Comment 2 EWS 2023-04-12 11:53:49 PDT 
Committed 262878@main (f7167b05ac1a): <https://commits.webkit.org/262878@main>

Reviewed commits have been landed. Closing PR #12659 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-04-12 11:54:15 PDT 
<rdar://problem/107951657>