WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
255340
[ews] Add a script to upload a file to given url
https://bugs.webkit.org/show_bug.cgi?id=255340
Summary
[ews] Add a script to upload a file to given url
Aakash Jain
Reported
2023-04-12 07:32:33 PDT
Write a script to upload a file to given url. This would be used by
https://bugs.webkit.org/show_bug.cgi?id=255339
"EWS bots should upload directly to S3"
Attachments
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2023-04-12 07:36:10 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/12650
EWS
Comment 2
2023-04-12 14:56:55 PDT
Committed
262888@main
(ab2b21fb6389): <
https://commits.webkit.org/262888@main
> Reviewed commits have been landed. Closing PR #12650 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-04-12 14:57:19 PDT
<
rdar://problem/107961097
>
EWS
Comment 4
2023-04-25 14:49:13 PDT
Committed
259548.688@safari-7615-branch
(0500e7adcfa5): <
https://commits.webkit.org/259548.688@safari-7615-branch
> Reviewed commits have been landed. Closing PR #559 and removing active labels.
Aakash Jain
Comment 5
2023-04-27 04:20:30 PDT
Re-opening for pull request
https://github.com/apple/WebKit/pull/559
Claudio Saavedra
Comment 6
2023-05-24 09:02:25 PDT
From
https://bugs.webkit.org/show_bug.cgi?id=255819
, IIUC there's intention to remove usage of the requests module. Noticed some warnings in the GTK bots because requests is used (which doesn't seem to be installed) (
https://ews-build.webkit.org/#/builders/2/builds/9500
). Might be a good idea to update the script ot move away from it.
Aakash Jain
Comment 7
2023-05-24 09:35:46 PDT
We don't have concern with request module as such. The reason for the change in
https://bugs.webkit.org/show_bug.cgi?id=255819
is for the code running on server side to convert from synchronous to async code. If you notice error due to missing requests module on any of your bots, please install requests module.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug