Bug 255286 – AX: Create TextMarkerRanges based on the TextContent of AXIsolatedObjects.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andres Gonzalez]

Needed for stringForTextMarkerRange.

[Radar WebKit Bug Importer]

<rdar://problem/107883608>

[Andres Gonzalez]

Created attachment 465847 [details]
Patch

[Tyler Wilcock]

Comment on attachment 465847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465847&action=review

Looks good to me once all EWS tests pass. I'd understand if you didn't want to wait through another round of EWS just to fix some typos in the commit message, up to you.

> COMMIT_MESSAGE:7
> +TextMarkerRanges were created using the cached AttributedString for some types of AXIsoaltedObjects. However, we need to create TesxtMarkerRanges for objects for which there is no cached AttributedString. This patch uses the TextContent property instead of the cached AttributedString.

Typos:

AXIsoaltedObjects
TesxtMarkerRanges

> COMMIT_MESSAGE:11
> +This is needed to implement AXIsolatedObject::stringForTextMarkerRange and related methods off the main thtread.

Typo: thtread

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 465847 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=465847&action=review
> 
> Looks good to me once all EWS tests pass. I'd understand if you didn't want
> to wait through another round of EWS just to fix some typos in the commit
> message, up to you.
> 
> > COMMIT_MESSAGE:7
> > +TextMarkerRanges were created using the cached AttributedString for some types of AXIsoaltedObjects. However, we need to create TesxtMarkerRanges for objects for which there is no cached AttributedString. This patch uses the TextContent property instead of the cached AttributedString.
> 
> Typos:
> 
> AXIsoaltedObjects
> TesxtMarkerRanges
> 
> > COMMIT_MESSAGE:11
> > +This is needed to implement AXIsolatedObject::stringForTextMarkerRange and related methods off the main thtread.
> 
> Typo: thtread

Thanks! will correct the typos before landing.

[EWS]

Committed 262835@main (14be4a13b9fa): <https://commits.webkit.org/262835@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465847 [details].