Do not instantiate hidden WebInspector panels. Otherwise they are hitting unimplemented InspectorController methods.
Created attachment 29963 [details] patch
Comment on attachment 29963 [details] patch This looks good. A couple code style things i would like to see changed — that I want to put in our official style rules. 1. Use "===" or "!--" when you know the types already match. 2. Use double quotes fore al string literals.
Created attachment 29964 [details] post-review patch
(In reply to comment #2) > (From update of attachment 29963 [details] [review]) > This looks good. A couple code style things i would like to see changed — that > I want to put in our official style rules. > > 1. Use "===" or "!--" when you know the types already match. > 2. Use double quotes fore al string literals. > Done. Interestingly, we only use single quotes for JS and are almost never using === at Google. Talking about the ===, does it give any performance boost? (Or why do you want to enforce it?)
Dear committers, could you please land tiny patch? (Dmitry, who is usually doing this for me, is going to by out on Monday).
(In reply to comment #4) > Done. Interestingly, we only use single quotes for JS and are almost never > using === at Google. Talking about the ===, does it give any performance boost? > (Or why do you want to enforce it?) There is a slight performance increase since it says "i know the types of these two things, don't try to convert them to another type to compare, otherwise be false".
Landed in r43185.