RESOLVED FIXED 25520
Do not instantiate hidden WebInspector panels. 
https://bugs.webkit.org/show_bug.cgi?id=25520
Summary Do not instantiate hidden WebInspector panels.
Pavel Feldman
Reported 2009-05-03 01:17:12 PDT
Do not instantiate hidden WebInspector panels. Otherwise they are hitting unimplemented InspectorController methods.
Attachments
patch (2.32 KB, patch)
2009-05-03 01:19 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
post-review patch (2.32 KB, patch)
2009-05-03 03:56 PDT, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-05-03 01:19:41 PDT
Created attachment 29963 [details] patch
Timothy Hatcher
Comment 2 2009-05-03 03:33:00 PDT
Comment on attachment 29963 [details] patch This looks good. A couple code style things i would like to see changed — that I want to put in our official style rules. 1. Use "===" or "!--" when you know the types already match. 2. Use double quotes fore al string literals.
Pavel Feldman
Comment 3 2009-05-03 03:56:18 PDT
Created attachment 29964 [details] post-review patch
Pavel Feldman
Comment 4 2009-05-03 04:01:54 PDT
(In reply to comment #2) > (From update of attachment 29963 [details] [review]) > This looks good. A couple code style things i would like to see changed — that > I want to put in our official style rules. > > 1. Use "===" or "!--" when you know the types already match. > 2. Use double quotes fore al string literals. > Done. Interestingly, we only use single quotes for JS and are almost never using === at Google. Talking about the ===, does it give any performance boost? (Or why do you want to enforce it?)
Pavel Feldman
Comment 5 2009-05-03 04:11:25 PDT
Dear committers, could you please land tiny patch? (Dmitry, who is usually doing this for me, is going to by out on Monday).
Timothy Hatcher
Comment 6 2009-05-03 08:50:58 PDT
(In reply to comment #4) > Done. Interestingly, we only use single quotes for JS and are almost never > using === at Google. Talking about the ===, does it give any performance boost? > (Or why do you want to enforce it?) There is a slight performance increase since it says "i know the types of these two things, don't try to convert them to another type to compare, otherwise be false".
Peter Kasting
Comment 7 2009-05-04 10:51:06 PDT
Landed in r43185.
Note You need to log in before you can comment on or make changes to this bug.