WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
255121
[prepare-commit-msg] Fix 'git commit --reedit-message'
https://bugs.webkit.org/show_bug.cgi?id=255121
Summary
[prepare-commit-msg] Fix 'git commit --reedit-message'
Jonathan Bedard
Reported
2023-04-06 15:02:41 PDT
While 'git commit --amend' works, that's only because we hard-code HEAD in our prepare-commit-msg hook. We should instead use the argument 'git commit' is providing us.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-04-06 15:02:56 PDT
<
rdar://problem/107729416
>
Jonathan Bedard
Comment 2
2023-04-06 15:06:06 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/12480
EWS
Comment 3
2023-04-06 15:12:21 PDT
Committed
262688@main
(ba739f2564d7): <
https://commits.webkit.org/262688@main
> Reviewed commits have been landed. Closing PR #12480 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug