Bug 25509 - [GTK] Missing accelerator in authentication dialog
Summary: [GTK] Missing accelerator in authentication dialog
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-05-01 01:46 PDT by Luca Ferretti
Modified: 2009-07-21 04:21 PDT (History)
3 users (show)

See Also:

webkit-bug-25509-add-accelerator (1.94 KB, patch)
2009-07-20 15:33 PDT, Priit Laes (IRC: plaes)
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luca Ferretti 2009-05-01 01:46:32 PDT
Translating webkitgtk I found this message:

  #: WebKit/gtk/webkit/webkitsoupauthdialog.c:281
  msgid "Remember password"

It's referred to 
  checkButton = gtk_check_button_new_with_label(_("Remember password"));
in source code.

As per GNOME HIG, this checkbox should have an accelerator.
Comment 1 Priit Laes (IRC: plaes) 2009-07-20 15:33:28 PDT
Created attachment 33116 [details]
Comment 2 Holger Freyther 2009-07-20 20:20:16 PDT
Comment on attachment 33116 [details]

As of http://library.gnome.org/devel/hig-book/stable/controls-check-boxes.html.en...
Comment 3 Gustavo Noronha (kov) 2009-07-21 04:05:46 PDT
Landed as r46169.
Comment 4 Luca Ferretti 2009-07-21 04:21:09 PDT
Silly question: POT file needs to be manually updated in order to have this changed message in translations, isn't it?