Bug 25501 – Extra font tag created when changing fonts

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Annie Sullivan]

Steps to reproduce:
1. Go to Midas Demo: http://www.mozilla.org/editor/midasdemo/
2. Enter the following HTML:
<font face="Arial">text</font>
(This is what IE generates when setting the font to Arial.)
3. Uncheck "View HTML Source", highlight "text", and change font to Courier.

Actual result:
<font><font class="Apple-style-span" face="Courier">text</font></font>

Expected result:
<font class="Apple-style-span" face="Courier">text</font>
or just
<font face="Courier">text</font>

Lots of editing on different browsers can result in a document filling up with redundant tags. This makes it harder and harder to change the font correctly on all browsers.

[Tony Chang]

Created attachment 47099 [details]
Patch

[Tony Chang]

(In reply to comment #1)
> Created an attachment (id=47099) [details]
> Patch

I think the original code wasn't removing the extra font tag because it didn't create the font tag.  That said, that seems like a silly reason to keep the extra font tag.  E.g., if you unbold a section, webkit doesn't care who created the <b> tags and just remove them.

[Darin Adler]

Comment on attachment 47099 [details]
Patch

r=me

[Tony Chang]

Created attachment 47159 [details]
Patch

[Tony Chang]

Comment on attachment 47159 [details]
Patch

(same as before with better layout test that uses dumpAsText)

[WebKit Commit Bot]

Comment on attachment 47159 [details]
Patch

Clearing flags on attachment: 47159

Committed r53680: <http://trac.webkit.org/changeset/53680>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.