WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
254965
postprocess-asm rule doesn't respect RUBY_EXECUTABLE
https://bugs.webkit.org/show_bug.cgi?id=254965
Summary
postprocess-asm rule doesn't respect RUBY_EXECUTABLE
Sam James
Reported
2023-04-03 20:38:43 PDT
Originally reported downstream in Gentoo at
https://bugs.gentoo.org/771744
. WebKit allows overriding the Ruby version used for the build via RUBY_EXECUTABLE using a standard CMake mechanism and custom invocations use ${RUBY_EXECUTABLE} to ensure this is respected. The postprocess-asm rule is a bit different from some of the others, so it's been overlooked until now. It needs to use ${RUBY_EXECUTABLE} too, as postprocess-asm has a #!/usr/bin/env ruby shebang that will choose the first Ruby in path.
Attachments
Add attachment
proposed patch, testcase, etc.
Sam James
Comment 1
2023-04-03 20:39:47 PDT
PR:
https://github.com/WebKit/WebKit/pull/12358
EWS
Comment 2
2023-04-07 11:26:50 PDT
Committed
262719@main
(546b7119c8b7): <
https://commits.webkit.org/262719@main
> Reviewed commits have been landed. Closing PR #12358 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug