Bug 254833 - [ews-build.webkit.org] EWS does not extract clang linker errors well
Summary: [ews-build.webkit.org] EWS does not extract clang linker errors well
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-31 10:52 PDT by Darin Adler
Modified: 2023-04-03 09:19 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2023-03-31 10:52:13 PDT
This happened in <https://ews-build.webkit.org/#/builders/31/builds/1445>. The 3-line errors extract was:

(maybe you meant: WebKit::WebPageProxy::focusNextFocusedElement(bool, WTF::CompletionHandler<void ()>&&))
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

But the full 32k+ line build log also included these 4 lines:

Undefined symbols for architecture arm64:
  "WebKit::WebPageProxy::focusNextFocusedElement(bool)", referenced from:
      -[WKContentView(WKInteraction) focusedFormControlViewDidRequestNextNode:] in WKContentViewInteraction.o
      -[WKContentView(WKInteraction) focusedFormControlViewDidRequestPreviousNode:] in WKContentViewInteraction.o

I would have preferred the error extract to be these 5 lines:

Undefined symbols for architecture arm64:
  "WebKit::WebPageProxy::focusNextFocusedElement(bool)", referenced from:
      -[WKContentView(WKInteraction) focusedFormControlViewDidRequestNextNode:] in WKContentViewInteraction.o
      -[WKContentView(WKInteraction) focusedFormControlViewDidRequestPreviousNode:] in WKContentViewInteraction.o
(maybe you meant: WebKit::WebPageProxy::focusNextFocusedElement(bool, WTF::CompletionHandler<void ()>&&))

I don’t think we get a lot of error-understanding value out of "linker command failed with exit code 1", and we would get a *lot* of value out of the actual undefined symbols and then could omit "ld: symbol(s) not found for architecture arm64" since the only thing that adds is the name "ld".
Comment 1 Radar WebKit Bug Importer 2023-03-31 10:53:06 PDT
<rdar://problem/107479064>
Comment 2 Aakash Jain 2023-04-03 09:19:55 PDT
EWS is doing a simple string search for string: 'rror:' (and include few extra lines before the matched line to provide additional context).

Reference: searchString in BuildLogLineObserver at: https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/ews-build/steps.py#L2615


That doesn't seems helpful in this scenario. Seems like there is a scope of improvement here.