Bug 254820 – css/css-backgrounds/background-size-001.html is wrong

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Brent Fulgham]

This test now fails in an update of the WPT tests to 8f71659306c53f3cabad054ed02ac7c4d14de693.

[Radar WebKit Bug Importer]

<rdar://problem/107475107>

[Brent Fulgham]

Created attachment 465702 [details]
Diff of test case

Expectations changed from "{Something} auto" to just "{Something}"

[Karl Dubost]

Renaming the title
See http://wpt.live/css/css-backgrounds/background-size-001.html
https://wpt.fyi/results/css/css-backgrounds/background-size-001.html


With

```
data:text/html,<div id="test"></div>
```

and doing in the console.

```
> document.document.querySelector("#test").style.backgroundSize = "0px";
< "0px"
> window.getComputedStyle(document.querySelector("#test")).getPropertyValue("background-size")
< "0px auto"
> window.getComputedStyle(document.querySelector("#test")).backgroundSize
< "0px auto"
```

it should return `0px` only.

[Karl Dubost]

Probably done here. https://searchfox.org/wubkat/rev/d45649fa32a499702c30474e94bd6843c4c67849/Source/WebCore/css/ComputedStyleExtractor.cpp#2440-2453

[Karl Dubost]

This test is being contradicted by 
https://wpt.fyi/results/css/css-backgrounds/parsing/background-size-computed.html

[Karl Dubost]

I have a fix for adjusting to http://wpt.live/css/css-backgrounds/background-size-001.html

[Karl Dubost]

So wait, there are a couple of things to change in fact. 
WebKit has the correct behavior in this instance, but some tests need to be modified. 

Tim added it to the CSS WG agenda
Agenda+ to https://github.com/w3c/csswg-drafts/issues/7802 

and see for previous discussions 
https://github.com/WebKit/WebKit/pull/3372

[Karl Dubost]

Pull request: https://github.com/WebKit/WebKit/pull/37148

[EWS]

Committed 287112@main (3d8628034199): <https://commits.webkit.org/287112@main>

Reviewed commits have been landed. Closing PR #37148 and removing active labels.