WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
REOPENED
254788
Remove Quirk needsPerDocumentAutoplayBehavior for Netflix.com
https://bugs.webkit.org/show_bug.cgi?id=254788
Summary
Remove Quirk needsPerDocumentAutoplayBehavior for Netflix.com
Karl Dubost
Reported
2023-03-30 17:49:17 PDT
In
Bug 173030
, a quirk has been added for Netflix.com Code
https://github.com/WebKit/WebKit/blob/7e8331b4cad9e69af27575d0ada29e950e33f059/Source/WebCore/page/Quirks.cpp#L131-L139
With ear detection enabled, when I a bud is out of ear, the sound should pause. Steps To Reproduce: 1. Connect airpods to a laptop 2. Watch Netflix 3. Take one bud out of ear Results: Audio/Video continue to play If/when the issue doesn't reproduce, remove the Quirk.
Attachments
Add attachment
proposed patch, testcase, etc.
Karl Dubost
Comment 1
2023-03-30 17:50:01 PDT
rdar://107428381
Karl Dubost
Comment 2
2023-07-13 00:14:15 PDT
It has been tested on March 31, 2023. And taking out one bug and the audio/video stopped playing.
Brandon
Comment 3
2023-08-07 13:04:25 PDT
https://github.com/WebKit/WebKit/pull/16445
EWS
Comment 4
2023-08-07 13:22:13 PDT
Committed
266653@main
(24c3998f7296): <
https://commits.webkit.org/266653@main
> Reviewed commits have been landed. Closing PR #16445 and removing active labels.
WebKit Commit Bot
Comment 5
2023-08-08 09:38:09 PDT
Re-opened since this is blocked by
bug 259933
Karl Dubost
Comment 6
2023-08-09 21:22:01 PDT
The test on this bug and the subsequent patch are not about needsSeekingSupportDisabled. There is a mistake which propagated in between two different quirks about Netflix.
https://searchfox.org/wubkat/source/Source/WebCore/page/Quirks.cpp#131
needsSeekingSupportDisabled()
https://searchfox.org/wubkat/source/Source/WebCore/page/Quirks.cpp#141
needsPerDocumentAutoplayBehavior()
Karl Dubost
Comment 7
2023-08-09 21:22:43 PDT
I will rename this bug to needsPerDocumentAutoplayBehavior
Karl Dubost
Comment 8
2023-08-09 22:56:28 PDT
That said, I'm still not sure that removing needsPerDocumentAutoplayBehavior will solve more issues than creating new or old ones. We need more testing on the consequences of removing this Quirk too.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug