Bug 25474 - fix skipped windows tests from r43007
Summary: fix skipped windows tests from r43007
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-29 19:06 PDT by Ojan Vafai
Modified: 2009-04-30 14:46 PDT (History)
1 user (show)

See Also:


Attachments
2009-04-29 Ojan Vafai <ojan@chromium.org> (25.58 KB, patch)
2009-04-29 19:18 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff
2009-04-29 Ojan Vafai <ojan@chromium.org> (28.80 KB, patch)
2009-04-30 14:24 PDT, Ojan Vafai
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2009-04-29 19:06:03 PDT
http://trac.webkit.org/changeset/43007 added 3 tests to the windows skipped lists that have mac-specific metrics in them. They should be fixed appropriately.
Comment 1 Ojan Vafai 2009-04-29 19:18:38 PDT
Created attachment 29901 [details]
2009-04-29  Ojan Vafai  <ojan@chromium.org>


        Reviewed by NOBODY (OOPS!).

        Fix tests that depend on Mac-specific metrics now that text controls
        are sized according to font metrics (r43007).

        Fixes https://bugs.webkit.org/show_bug.cgi?id=25474.

        * fast/forms/textarea-appearance-wrap-expected.txt:
        * fast/forms/textarea-appearance-wrap.html:
        * fast/forms/textarea-hard-linewrap.html:
        These three tests only really care that a line-wrap character is submitted
        with forms that have the appropriate wrap value and not with other forms.
        So checking that the submit contents have a line-wrap character, instead of
        looking for it in a specific place, is sufficient. This gets around that we
        wrap in a different place in some cases on Mac and Windows.

        * fast/replaced/table-percent-height-expected.txt:
        * fast/replaced/table-percent-height-text-controls-expected.txt: Added.
        * fast/replaced/table-percent-height-text-controls.html: Added.
        * fast/replaced/table-percent-height.html:
        * platform/win/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
        Pulled out the cases in table-percent-height.html that had text controls and moved
        them into their own test. The new test doesn't assert specific metrics, it just
        spits them out. This allows us to have different expected results for Windows and
        Mac without having "FAIL" messages in the expected results. It's not perfect, but
        it seems better than any alternatives I could come up with.

        * platform/win/Skipped:
---
 10 files changed, 210 insertions(+), 118 deletions(-)
Comment 2 Ojan Vafai 2009-04-30 14:24:28 PDT
Created attachment 29922 [details]
2009-04-29  Ojan Vafai  <ojan@chromium.org>


        Reviewed by NOBODY (OOPS!).

        Fix tests that depend on Mac-specific metrics now that text controls
        are sized according to font metrics (r43007).

        Fixes https://bugs.webkit.org/show_bug.cgi?id=25474.

        * fast/forms/textarea-appearance-wrap-expected.txt:
        * fast/forms/textarea-appearance-wrap.html:
        * fast/forms/textarea-hard-linewrap.html:
        These three tests only really care that a line-wrap character is submitted
        with forms that have the appropriate wrap value and not with other forms.
        So checking that the submit contents have a line-wrap character, instead of
        looking for it in a specific place, is sufficient. This gets around that we
        wrap in a different place in some cases on Mac and Windows.

        * fast/replaced/table-percent-height-expected.txt:
        * fast/replaced/table-percent-height-text-controls-expected.txt: Added.
        * fast/replaced/table-percent-height-text-controls.html: Added.
        * fast/replaced/table-percent-height.html:
        * platform/win/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
        Pulled out the cases in table-percent-height.html that had text controls and moved
        them into their own test. The new test doesn't assert specific metrics, it just
        spits them out. This allows us to have different expected results for Windows and
        Mac without having "FAIL" messages in the expected results. It's not perfect, but
        it seems better than any alternatives I could come up with.

        * platform/win/Skipped:
---
 11 files changed, 325 insertions(+), 150 deletions(-)
Comment 3 Eric Seidel (no email) 2009-04-30 14:29:38 PDT
Comment on attachment 29922 [details]
2009-04-29  Ojan Vafai  <ojan@chromium.org>

Looks good.  I don't need to see this again.  We talked about terser options.  Pick one, and land it. :)
Comment 4 Ojan Vafai 2009-04-30 14:46:55 PDT
http://trac.webkit.org/changeset/43099