WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
254717
Consider moving wtf/fast_float to a ThirdParty directory
https://bugs.webkit.org/show_bug.cgi?id=254717
Summary
Consider moving wtf/fast_float to a ThirdParty directory
Elliott Williams
Reported
2023-03-29 19:28:14 PDT
Right now, it's not clear that we bundle fast_float <
https://github.com/fastfloat/fast_float
> inside of WTF. There is precedent for a ThirdParty directory nested inside a project directory, e.g. Source/WebCore/PAL/ThirdParty/libavif/. We should do the same thing for fast_float and move it to Source/WTF/ThirdParty/fast_float/. This ought to be useful for distributions tracking which copyrighted works they ship, and it makes it easier to understand why code is that directory does not always conform to coding style, etc.
Attachments
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2023-04-03 06:05:59 PDT
This Apache-licensed code changes the "effective license" of WebKit. I thought WebKit's license was (BSD and LGPLv2+), but surprise! it's actually (BSD and LPGLv2+ and Apache). Notably, it means GPLv2-only applications cannot depend on WebKit (although, fortunately, I doubt any such applications exist). We need to get the license right. This means either removing this code or else updating
https://webkit.org/licensing-webkit/
Yusuke Suzuki
Comment 2
2023-04-03 09:18:06 PDT
(In reply to Michael Catanzaro from
comment #1
)
> This Apache-licensed code changes the "effective license" of WebKit. I > thought WebKit's license was (BSD and LGPLv2+), but surprise! it's actually > (BSD and LPGLv2+ and Apache). Notably, it means GPLv2-only applications > cannot depend on WebKit (although, fortunately, I doubt any such > applications exist). > > We need to get the license right. This means either removing this code or > else updating
https://webkit.org/licensing-webkit/
libwebrtc is Apache license for example.
Yusuke Suzuki
Comment 3
2023-04-03 09:20:30 PDT
Also, ANGLE, pdfjs
Michael Catanzaro
Comment 4
2023-04-03 10:09:09 PDT
OK, we need to update
https://webkit.org/licensing-webkit/
Radar WebKit Bug Importer
Comment 5
2023-04-05 19:29:18 PDT
<
rdar://problem/107690836
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug