Bug 25471 - fast/forms/textarea-metrics.html failing on windows
Summary: fast/forms/textarea-metrics.html failing on windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-29 16:47 PDT by Ojan Vafai
Modified: 2009-04-29 17:42 PDT (History)
0 users

See Also:

Attachments
2009-04-29 Ojan Vafai <ojan@chromium.org> (9.74 KB, patch)
2009-04-29 17:19 PDT, Ojan Vafai 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2009-04-29 16:47:11 PDT 
The expected results are just wrong. There's a race with JS tests that have setTimeouts in them. See http://build.webkit.org/results/Windows%20Release%20(Tests)/r43017%20(546)/fast/forms/textarea-metrics-pretty-diff.html and bug 25469.

For now the test just needs to be modified to not use a setTimeout.
Comment 1 Ojan Vafai 2009-04-29 17:19:38 PDT 
Created attachment 29899 [details]
2009-04-29  Ojan Vafai  <ojan@chromium.org>


        Reviewed by NOBODY (OOPS!).

        Fix this test to only use a setTimeout in IE.
        It doesn't need a timeout in WebKit and the
        timeout requires using waitUntilDone/notifyDone,
        which doesn't play nicely with JS tests.

        See https://bugs.webkit.org/show_bug.cgi?id=25471

        * fast/forms/resources/textarea-metrics.js:
        (assertTextareaMetrics):
        * fast/forms/textarea-metrics-expected.txt:
        * platform/win/fast/forms/textarea-metrics-expected.txt:
        * platform/win/Skipped:
---
 5 files changed, 60 insertions(+), 60 deletions(-)
Comment 2 Eric Seidel (no email) 2009-04-29 17:22:17 PDT 
Comment on attachment 29899 [details]
2009-04-29  Ojan Vafai  <ojan@chromium.org>

r=me
Comment 3 Ojan Vafai 2009-04-29 17:42:07 PDT 
http://trac.webkit.org/changeset/43031