Bug 254638 - Remove Quirk shouldAdvertiseSupportForHLSSubtitleTypes on hulu.com
Summary: Remove Quirk shouldAdvertiseSupportForHLSSubtitleTypes on hulu.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Karl Dubost
URL: http://hulu.com/
Keywords: BrowserCompat, InRadar
Depends on: 254605
Blocks:
  Show dependency tree / graph
 
Reported: 2023-03-28 19:11 PDT by Karl Dubost
Modified: 2023-08-15 14:24 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Dubost 2023-03-28 19:11:59 PDT 
This is to not forget to remove the quirk when this is not necessary anymore. 

Steps to reproduce:

1. With an iPad 
2. Go to to hulu.com
3. Log in
4. Play a video

Result:
Video Error


The Quirk has been created in 
* https://github.com/WebKit/WebKit/pull/12065
* Bug 254605

Recent changes in the AVFoundation framework have caused canPlayType() queries for
`application/vnd.apple.mpegurl; codecs="stpp.ttml.im1t"` and
`application/vnd.apple.mpegurl; codecs="wvtt"` to fail. These were never well-formed
queries in the first place, as `application/vnd.apple.mpegurl` does not take a codecs
parameter. However, Hulu.com appears to depend upon those queries returning "probably"
in order to vend a working HLS stream.

Add a quirk for hulu.com only which hard codes the answer to those two canPlayType()
queries to "probably".
Comment 1 Radar WebKit Bug Importer 2023-03-28 19:13:07 PDT 
<rdar://problem/107347115>
Comment 2 Karl Dubost 2023-08-13 18:56:48 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16655
Comment 3 EWS 2023-08-15 14:24:31 PDT 
Committed 266925@main (44e22d905dd0): <https://commits.webkit.org/266925@main>

Reviewed commits have been landed. Closing PR #16655 and removing active labels.