RESOLVED FIXED 254627
[git-webkit] Prevent publication of commits for redacted PRs 
https://bugs.webkit.org/show_bug.cgi?id=254627
Summary [git-webkit] Prevent publication of commits for redacted PRs
Jonathan Bedard
Reported 2023-03-28 16:36:36 PDT
By design, git-webkit makes it very hard to opt-in to publishing a fix for a redacted PR. The recent addition of a pre-push hook makes this less crucial, because regardless of how a user answers prompts by `git-webkit`, any push containing a redacted issue will prompt the user before contacting the server. `git-webkit` should respect a user when they explicitly request to make a fix for a redacted issue public.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-03-28 17:18:00 PDT
<rdar://problem/107343169>
Jonathan Bedard
Comment 2 2023-03-29 07:01:08 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12110
Jonathan Bedard
Comment 3 2023-04-05 11:39:52 PDT
After talking with Geoff and landing https://commits.webkit.org/262617@main, we're basically going to do the exact opposite of this: we're going to forbid publication of commits for redacted PRs in all circumstances. I'm going to re-purpose this bug because anyone following it already will care about us doing the inverse.
EWS
Comment 4 2023-04-18 15:36:44 PDT
Committed 263101@main (9384f300d865): <https://commits.webkit.org/263101@main> Reviewed commits have been landed. Closing PR #12110 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.