It seems that the calls to roundToDevicePixel() were dropped in http://trac.webkit.org/changeset/34210 This results in blurry images when zoomed out as the images are not aligned to pixel boundaries. I spoke with the author of r34210 change and he said that it caused some regression of images. After some investigation, the regression seems to be because of the srcRect being aligned as well as the destination rect. I would like to restore this feature.
Created attachment 29864 [details] patch
Ran DRT and there was no regressions on my platform.
Comment on attachment 29864 [details] patch r=me
Didn't run pixel tests. When I run those, these tests have an issue: svg/W3C-SVG-1.1/render-groups-03-t.svg expected image image diffs 0.16% svg/carto.net/scrollbar.svg expected image image diffs 0.15% svg/custom/focus-ring.svg expected image image diffs 0.19% svg/custom/image-small-width-height.svg expected image image diffs 0.33%
With the test case: svg/custom/focus-ring.svg The focus ring is now in the correct place! With the test case: svg/custom/image-small-width-height.svg There was slight blurriness where the blue bar meets the green checker pattern. The line is now much sharper.
This pixel test seems to have regressed with this patch: fast/repaint/fixed.html
(In reply to comment #6) > This pixel test seems to have regressed with this patch: > fast/repaint/fixed.html Mitz informs me this is: https://bugs.webkit.org/show_bug.cgi?id=25269 Since the test is already broken, I will check in new results with this patch.
$ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum M LayoutTests/platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png M LayoutTests/platform/mac/svg/custom/focus-ring-expected.checksum M LayoutTests/platform/mac/svg/custom/focus-ring-expected.png M LayoutTests/platform/mac/svg/custom/image-small-width-height-expected.checksum M LayoutTests/platform/mac/svg/custom/image-small-width-height-expected.png M WebCore/ChangeLog M WebCore/platform/graphics/cg/ImageCG.cpp Committed r42987 http://trac.webkit.org/changeset/42987
This change caused bug 25476.
Reopening as this change was backed out for Bug 25476.
Comment on attachment 29864 [details] patch Clearing r+ to move out of commit queue (and since the change was backed out due to some failed test).