WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
254562
WebKit needs to pass along NotificationOptions.silent to API clients
https://bugs.webkit.org/show_bug.cgi?id=254562
Summary
WebKit needs to pass along NotificationOptions.silent to API clients
lehu
Reported
2023-03-27 18:50:18 PDT
Notification pushed by WebPush does not play alert sound both on iOS and macOS. And here is a demo to reoccur this issue.
https://bugs.webkit.org/show_bug.cgi?id=252544#c3
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-03-30 09:29:29 PDT
<
rdar://problem/107424158
>
Brady Eidson
Comment 2
2023-04-19 19:49:41 PDT
WebKit itself does not display notifications, and cannot affect whether or not sound plays. But for clients to be able to make the "sound or silent?" decision, WebKit needs to pass along the silent flag from NotificationOptions. Let's do that here. Retitling to: WebKit needs to pass along NotificationOptions.silent to API clients
Brady Eidson
Comment 3
2023-04-19 19:59:19 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/12953
EWS
Comment 4
2023-04-20 11:38:40 PDT
Committed
263184@main
(c33fee9a5907): <
https://commits.webkit.org/263184@main
> Reviewed commits have been landed. Closing PR #12953 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug