Bug 254562 - WebKit needs to pass along NotificationOptions.silent to API clients
Summary: WebKit needs to pass along NotificationOptions.silent to API clients
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: Safari 16
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-27 18:50 PDT by lehu
Modified: 2023-04-20 11:38 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description lehu 2023-03-27 18:50:18 PDT
Notification pushed by WebPush does not play alert sound both on iOS and macOS.

And here is a demo to reoccur this issue.

https://bugs.webkit.org/show_bug.cgi?id=252544#c3
Comment 1 Radar WebKit Bug Importer 2023-03-30 09:29:29 PDT
<rdar://problem/107424158>
Comment 2 Brady Eidson 2023-04-19 19:49:41 PDT

WebKit itself does not display notifications, and cannot affect whether or not sound plays.

But for clients to be able to make the "sound or silent?" decision, WebKit needs to pass along the silent flag from NotificationOptions.

Let's do that here. Retitling to:
WebKit needs to pass along NotificationOptions.silent to API clients
Comment 3 Brady Eidson 2023-04-19 19:59:19 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12953
Comment 4 EWS 2023-04-20 11:38:40 PDT
Committed 263184@main (c33fee9a5907): <https://commits.webkit.org/263184@main>

Reviewed commits have been landed. Closing PR #12953 and removing active labels.