Bug 254553 - Webassembly enabled build failed for RISCV64
Summary: Webassembly enabled build failed for RISCV64
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-27 16:09 PDT by Khem Raj
Modified: 2023-05-05 10:35 PDT (History)
3 users (show)

See Also:


Attachments
Workaround patch (550 bytes, text/plain)
2023-03-27 16:13 PDT, Khem Raj
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Khem Raj 2023-03-27 16:09:58 PDT
Starting Webkit 2.40 it does not build for RISCV64 as the build fails in Wasm support. It worked ok with 2.38

../webkitgtk-2.40.0/Source/JavaScriptCore/wasm/WasmCallee.h:95:47: error: member access into incomplete type 'JSC::Co         mpilation'                                                                                                                         void* start = m_entrypoint.compilation->codeRef().executableMemory()->start().untaggedPtr();                    66428 |                                               ^                                                                          ../webkitgtk-2.40.0/Source/JavaScriptCore/wasm/WasmFormat.h:49:7: note: forward declaration of 'JSC::Compilation'       66430 | class Compilation;                                                                                                             ^                                                                                                                 66432 | In file included from ../webkitgtk-2.40.0/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:57:                     66433 | In file included from ../webkitgtk-2.40.0/Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.h:31:                     66434 | In file included from ../webkitgtk-2.40.0/Source/JavaScriptCore/wasm/js/JSWebAssemblyGlobal.h:33:                       66435 | In file included from ../webkitgtk-2.40.0/Source/JavaScriptCore/wasm/js/WebAssemblyFunction.h:32:                       66436 | ../webkitgtk-2.40.0/Source/JavaScriptCore/wasm/WasmCallee.h:96:45: error: member access into incomplete type 'JSC::Co         mpilation'                                                                                                                         void* end = m_entrypoint.compilation->codeRef().executableMemory()->end().untaggedPtr();                        66438 |                                             ^                                                                            ../webkitgtk-2.40.0/Source/JavaScriptCore/wasm/WasmFormat.h:49:7: note: forward declaration of 'JSC::Compilation'       66440 | class Compilation;                                                                                                             ^                                                                                                                 66442 | In file included from ../webkitgtk-2.40.0/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:57:                     66443 | In file included from ../webkitgtk-2.40.0/Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.h:31:                     66444 | In file included from ../webkitgtk-2.40.0/Source/JavaScriptCore/wasm/js/JSWebAssemblyGlobal.h:33:                       66445 | In file included from ../webkitgtk-2.40.0/Source/JavaScriptCore/wasm/js/WebAssemblyFunction.h:32:                       66446 | ../webkitgtk-2.40.0/Source/JavaScriptCore/wasm/WasmCallee.h:100:86: error: member access into incomplete type 'JSC::C         ompilation'                                                                                                                    CodePtr<WasmEntryPtrTag> entrypointImpl() const { return m_entrypoint.compilation->code().retagged<WasmEntryPtrTa         g>(); }                                                                                                                                                                                                         ^
Comment 1 Khem Raj 2023-03-27 16:13:03 PDT
Created attachment 465620 [details]
Workaround patch

This patch adds a way to disable wasm on RV64, which was always enabled
Comment 2 Radar WebKit Bug Importer 2023-04-03 16:10:15 PDT
<rdar://problem/107582046>