Bug 254515 - [WGSL] Add type declarations for textureSample overloads that operate on texture_depth_*
Summary: [WGSL] Add type declarations for textureSample overloads that operate on text...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-27 06:45 PDT by Tadeu Zagallo
Modified: 2023-09-22 08:51 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2023-03-27 06:45:20 PDT 
We have declared all the versions that operate on texture, but we don't yet support texture_depth, so the following methods are missing:

A is i32, or u32	
@must_use fn textureSample(t: texture_depth_2d_array,
                           s: sampler,
                           coords: vec2<f32>,
                           array_index: A,
                           offset: vec2<i32>) -> f32

@must_use fn textureSample(t: texture_depth_cube,
                           s: sampler,
                           coords: vec3<f32>) -> f32
A is i32, or u32	
@must_use fn textureSample(t: texture_depth_cube_array,
                           s: sampler,
                           coords: vec3<f32>,
                           array_index: A) -> f32
Comment 1 Radar WebKit Bug Importer 2023-04-03 06:46:14 PDT 
<rdar://problem/107556432>
Comment 2 Tadeu Zagallo 2023-09-21 08:28:36 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18020
Comment 3 EWS 2023-09-22 08:51:20 PDT 
Committed 268315@main (d7e9dd0b2334): <https://commits.webkit.org/268315@main>

Reviewed commits have been landed. Closing PR #18020 and removing active labels.