Bug 25451 – Selection base/extent aren't honored on the first horizontal extension

• Status: RESOLVED
• Resolution: WONTFIX
• Component: HTML Editing

[Justin Garcia]

In editable content, create a selection from left to right, then extend the selection with shift-left.

The left side of the selection (instead of the extent) is modified.

See http://www.betalogue.com/2009/04/22/selections/ for a report of this.  We apparently match AppKit here but changing this seems sensible.

[Justin Garcia]

if (!m_lastChangeWasHorizontalExtension) {
    m_lastChangeWasHorizontalExtension = true;
    Position start = m_sel.start();
    Position end = m_sel.end();
    switch (direction) {
        // FIXME: right for bidi?
        case RIGHT:
        case FORWARD:
            m_sel.setBase(start);
            m_sel.setExtent(end);
            break;
        case LEFT:
        case BACKWARD:
            m_sel.setBase(end);
            m_sel.setExtent(start);
            break;
    }
}

[Justin Garcia]

http://trac.webkit.org/changeset/7608

[Justin Garcia]

I think we continue to reset the base/extent if you double or triple click and then start extending.

[Justin Garcia]

I meant "I think we should continue to reset the base/extent if you double or triple click and then start extending".

[Justin Garcia]

Created attachment 29860 [details]
patch w/o layout tests or changelog

fixes the bug.  no layout test yet though.  I'm going to come back to this.

[Justin Garcia]

This behavior matches the HIG: http://developer.apple.com/documentation/UserExperience/Conceptual/AppleHIGuidelines/XHIGUserInput/XHIGUserInput.html#//apple_ref/doc/uid/TP30000361-TPXREF17

Closing.