Bug 254492 – [IFC] Incorrect out-of-flow box placement when text-indent is present (display: inline)

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[zalan]

Created attachment 465599 [details]
Patch

[zalan]

Created attachment 465613 [details]
[fast-cq]Patch

[EWS]

Committed 262170@main (fd637abec439): <https://commits.webkit.org/262170@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465613 [details].

[Radar WebKit Bug Importer]

<rdar://problem/107280354>

[Thomas Wisniewski [:twisniewski]]

zalan, the test-case in the commit here renders quite differently in Firefox and Chrome, and not at all like the expected.html. Is this expected?

[zalan]

(In reply to Thomas Wisniewski [:twisniewski] from comment #5)
> zalan, the test-case in the commit here renders quite differently in Firefox
> and Chrome, and not at all like the expected.html. Is this expected?
Here I was just matching the new inline layout codepath (IFC) with our legacy behavior (in retrospect, I should have named the files accordingly).

[Thomas Wisniewski [:twisniewski]]

Ah, I see, s Chrome and Firefox's behavior is still considered correct, and Safari is considered to be failing this test? Thanks for the clarification!

[zalan]

(In reply to Thomas Wisniewski [:twisniewski] from comment #7)
> Ah, I see, s Chrome and Firefox's behavior is still considered correct, and
> Safari is considered to be failing this test? 
I didn't look too closely. Let me look at these tests again.

[zalan]

(In reply to zalan from comment #8)
> (In reply to Thomas Wisniewski [:twisniewski] from comment #7)
> > Ah, I see, s Chrome and Firefox's behavior is still considered correct, and
> > Safari is considered to be failing this test? 
> I didn't look too closely. Let me look at these tests again.
Apparently all the block containers have "text-indent: each line" which, according to caniuse, FireFox does not support yet. No wonder rendering does not match.
(this is about testing out-of-flow static positioning with the origin display value of "inline" after the _last_ line with _text_indent_)

[Thomas Wisniewski [:twisniewski]]

Ah, you're right, that certainly does explain why the rendering would be different in Chrome and Firefox.

Maybe it's a good time to port these tests over to web platform tests, to further encourage other vendors to finish their implementations as well..