RESOLVED FIXED 254490
Serialising web fonts duplicates the font custom data in the GPUP 
https://bugs.webkit.org/show_bug.cgi?id=254490
Summary Serialising web fonts duplicates the font custom data in the GPUP
Matt Woodrow
Reported 2023-03-26 16:55:32 PDT
In the Web Process, all Font instances from the same web font share the same underlying font data (via Font::CreationData). When we serialise fonts to the GPUP we serialise the font data each time, resulting in extra memory usage and time spent parsing the data each time. <rdar://106965215>
Attachments
Add attachment proposed patch, testcase, etc.
Matt Woodrow
Comment 1 2023-03-26 17:17:58 PDT
Pull request: https://github.com/WebKit/WebKit/pull/11987
Matt Woodrow
Comment 2 2023-03-28 16:47:37 PDT
Pull request: https://github.com/apple/WebKit/pull/502
EWS
Comment 3 2023-03-29 01:06:17 PDT
Committed 262263@main (b917345920e9): <https://commits.webkit.org/262263@main> Reviewed commits have been landed. Closing PR #11987 and removing active labels.
Fujii Hironori
Comment 4 2023-03-30 13:44:22 PDT
Regressed: Bug 254708 – REGRESSION(262263@main) [Win] ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) in font tests
Simon Fraser (smfr)
Comment 5 2023-03-30 14:58:59 PDT
Right; reverting via bug 254774.
Matt Woodrow
Comment 6 2023-03-30 23:26:56 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/12221
EWS
Comment 7 2023-03-31 12:37:34 PDT
Committed 262435@main (403125028b31): <https://commits.webkit.org/262435@main> Reviewed commits have been landed. Closing PR #12221 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.