RESOLVED FIXED 25448
Reveal execution line after SourceFrame loading 
https://bugs.webkit.org/show_bug.cgi?id=25448
Summary Reveal execution line after SourceFrame loading
Yury Semikhatsky
Reported 2009-04-28 10:20:00 PDT
When its content is loaded SourceFrame updates current execution line but it doesn't reveal it. In case of asynchronous loading(in Chromium) current execution line stays hidden.
Attachments
Reveal current execution line(if any) when script source is loaded (578 bytes, patch)
2009-04-28 10:23 PDT, Yury Semikhatsky 		timothy: review-
DetailsFormatted DiffDiff
Reveal current execution line(if any) when script source is loaded (1.14 KB, patch)
2009-04-29 00:30 PDT, Yury Semikhatsky 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2009-04-28 10:23:13 PDT
Created attachment 29852 [details] Reveal current execution line(if any) when script source is loaded
Timothy Hatcher
Comment 2 2009-04-28 10:43:49 PDT
Comment on attachment 29852 [details] Reveal current execution line(if any) when script source is loaded > + if (this._executionLine) > + this.revealLine(this._executionLine); The change is correct. But please use 4 spaces instead of two for indentation. Also include a ChangeLog entry (use the prepare-ChangeLog script).
Yury Semikhatsky
Comment 3 2009-04-29 00:30:04 PDT
Created attachment 29880 [details] Reveal current execution line(if any) when script source is loaded
Yury Semikhatsky
Comment 4 2009-04-29 00:31:28 PDT
(In reply to comment #2) > (From update of attachment 29852 [details] [review]) > > + if (this._executionLine) > > + this.revealLine(this._executionLine); > > The change is correct. But please use 4 spaces instead of two for indentation. > > Also include a ChangeLog entry (use the prepare-ChangeLog script). > Done.
Timothy Hatcher
Comment 5 2009-04-29 10:38:32 PDT
Landed in r42997.
Note You need to log in before you can comment on or make changes to this bug.