Bug 25448 - Reveal execution line after SourceFrame loading
Summary: Reveal execution line after SourceFrame loading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-28 10:20 PDT by Yury Semikhatsky
Modified: 2009-04-29 10:38 PDT (History)
2 users (show)

See Also:


Attachments
Reveal current execution line(if any) when script source is loaded (578 bytes, patch)
2009-04-28 10:23 PDT, Yury Semikhatsky
timothy: review-
Details | Formatted Diff | Diff
Reveal current execution line(if any) when script source is loaded (1.14 KB, patch)
2009-04-29 00:30 PDT, Yury Semikhatsky
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2009-04-28 10:20:00 PDT
When its content is loaded SourceFrame updates current execution line but it doesn't reveal it. In case of asynchronous loading(in Chromium) current execution line stays hidden.
Comment 1 Yury Semikhatsky 2009-04-28 10:23:13 PDT
Created attachment 29852 [details]
Reveal current execution line(if any) when script source is loaded
Comment 2 Timothy Hatcher 2009-04-28 10:43:49 PDT
Comment on attachment 29852 [details]
Reveal current execution line(if any) when script source is loaded

> +        if (this._executionLine)
> +          this.revealLine(this._executionLine);

The change is correct. But please use 4 spaces instead of two for indentation.

Also include a ChangeLog entry (use the prepare-ChangeLog script).
Comment 3 Yury Semikhatsky 2009-04-29 00:30:04 PDT
Created attachment 29880 [details]
Reveal current execution line(if any) when script source is loaded
Comment 4 Yury Semikhatsky 2009-04-29 00:31:28 PDT
(In reply to comment #2)
> (From update of attachment 29852 [details] [review])
> > +        if (this._executionLine)
> > +          this.revealLine(this._executionLine);
> 
> The change is correct. But please use 4 spaces instead of two for indentation.
> 
> Also include a ChangeLog entry (use the prepare-ChangeLog script).
> 

Done.
Comment 5 Timothy Hatcher 2009-04-29 10:38:32 PDT
Landed in r42997.