Fallout from https://bugs.webkit.org/show_bug.cgi?id=252193.
<rdar://problem/107226245>
rdar://106958414
<rdar://problem/107226275>
Created attachment 465591 [details] Patch
Comment on attachment 465591 [details] Patch Good nuance to remember that apparently these ax attributes strings need CGcolors instead of NSColors Thanks!
Created attachment 465596 [details] Patch
> The cause of the problem was that we were setting the color attribute in the AttributedString using the NSColor pointer that is not retained after the caller of this function returns This explanation doesn’t make sense. Attributed strings retain the attributes, so the NSColor should be retained by the attributed string. There must be something else going on.
(In reply to Darin Adler from comment #7) > > The cause of the problem was that we were setting the color attribute in the AttributedString using the NSColor pointer that is not retained after the caller of this function returns > > This explanation doesn’t make sense. Attributed strings retain the > attributes, so the NSColor should be retained by the attributed string. > There must be something else going on. I talked to andres offline. This explanation isn't right. The problem was that AX system expects cgcolors instead of nscolors. Andres can you update the message
Committed 262126@main (ae7bf78d3f4f): <https://commits.webkit.org/262126@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465596 [details].
(In reply to Darin Adler from comment #7) > > The cause of the problem was that we were setting the color attribute in the AttributedString using the NSColor pointer that is not retained after the caller of this function returns > > This explanation doesn’t make sense. Attributed strings retain the > attributes, so the NSColor should be retained by the attributed string. > There must be something else going on. Corrected the code comment in https://bugs.webkit.org/show_bug.cgi?id=254486. Thanks for pointing out.