Bug 254450 - [ews-build] Make should_send_email_for_patch asynchronous
Summary: [ews-build] Make should_send_email_for_patch asynchronous
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-24 17:32 PDT by Jonathan Bedard
Modified: 2023-04-20 08:05 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.83 KB, patch)
2023-04-19 11:42 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Test patch (3.11 KB, patch)
2023-04-19 12:19 PDT, Jonathan Bedard 		jbedard: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-03-24 17:32:51 PDT 
should_send_email_for_patch should be asynchronous because it logs to the buildbot log. More important, our code which fetches a patch from bugzilla should be asynchronous, and that code is invoke from should_send_email_for_patch, so should_send_email_for_patch blocks making requests to Bugzilla asynchronous.
Comment 1 Radar WebKit Bug Importer 2023-03-24 17:33:57 PDT 
<rdar://problem/107209666>
Comment 2 Jonathan Bedard 2023-03-24 17:34:42 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11958
Comment 3 Jonathan Bedard 2023-04-19 11:42:28 PDT 
Created attachment 465984 [details]
Patch
Comment 4 Jonathan Bedard 2023-04-19 12:19:29 PDT 
Created attachment 465986 [details]
Test patch
Comment 5 EWS 2023-04-20 08:05:41 PDT 
Committed 263175@main (b98dad5b233f): <https://commits.webkit.org/263175@main>

Reviewed commits have been landed. Closing PR #11958 and removing active labels.