Bug 254446 - [ews-build.webkit.org] Make GitHubMixin.get_pr_json asynchronous
Summary: [ews-build.webkit.org] Make GitHubMixin.get_pr_json asynchronous
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-24 16:18 PDT by Jonathan Bedard
Modified: 2023-03-27 08:24 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-03-24 16:18:58 PDT 
GitHubMixin.get_pr_json makes a network request, so it should adopt Twisted's asynchronous request library.
Comment 1 Radar WebKit Bug Importer 2023-03-24 16:19:13 PDT 
<rdar://problem/107207345>
Comment 2 Jonathan Bedard 2023-03-24 16:21:07 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11954
Comment 3 EWS 2023-03-27 08:24:53 PDT 
Committed 262151@main (9a18fa3e56d4): <https://commits.webkit.org/262151@main>

Reviewed commits have been landed. Closing PR #11954 and removing active labels.