Bug 254420 - AX: Move AXStringForTextMarkerRange off of the main thread.
Summary: AX: Move AXStringForTextMarkerRange off of the main thread.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-24 07:34 PDT by Andres Gonzalez
Modified: 2023-03-24 09:51 PDT (History)
10 users (show)

See Also:

Attachments
Patch (23.50 KB, patch)
2023-03-24 07:52 PDT, Andres Gonzalez 		andresg_22: review?
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2023-03-24 07:34:56 PDT 
Improve performance in ITM.
Comment 1 Radar WebKit Bug Importer 2023-03-24 07:35:07 PDT 
<rdar://problem/107185989>
Comment 2 Andres Gonzalez 2023-03-24 07:52:15 PDT 
Created attachment 465571 [details]
Patch
Comment 3 chris fleizach 2023-03-24 09:48:06 PDT 
Comment on attachment 465571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465571&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:956
> +        if (start < text.length() && end <= text.length())

end is an index here right? so we would to make sure it's  just < text.length() ?

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:957
> +            return text.substring(start, end - start);

likewise if the last parameter is length do we want

end - start + 1

?

For example the text

"test"
start = 0
end = 3

?