WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
254405
[MSE] media/media-source/media-source-video-playback-quality.html is a constant failure with MockMSE in GPUP
https://bugs.webkit.org/show_bug.cgi?id=254405
Summary
[MSE] media/media-source/media-source-video-playback-quality.html is a consta...
Jean-Yves Avenard [:jya]
Reported
2023-03-24 05:13:48 PDT
With MockMSE running in the GPU process, the test is a permanent error. ``` RUN(sourceBuffer.appendBuffer(samples)) EVENT(updateend) RUN(quality = video.getVideoPlaybackQuality()) -EXPECTED (quality.totalVideoFrames == '8') OK -EXPECTED (quality.corruptedVideoFrames == '1') OK -EXPECTED (quality.droppedVideoFrames == '2') OK -EXPECTED (quality.totalFrameDelay == '3') OK +EXPECTED (quality.totalVideoFrames == '8'), OBSERVED '1' FAIL +EXPECTED (quality.corruptedVideoFrames == '1'), OBSERVED '0' FAIL +EXPECTED (quality.droppedVideoFrames == '2'), OBSERVED '1' FAIL +EXPECTED (quality.totalFrameDelay == '3'), OBSERVED '0' FAIL END OF TEST ``` The test waits for the `updateend` event to be fired on SourceBuffer before calling `getVideoPlaybackQuality` , but this would only work when the MockMSE runs in the content process due to an implementation detailed with the MockMediaPlayerMediaSource: it updates the time and playback quality immediately. However, in practice this is rather nonsensical, we can only expect the VideoPlaybackQuality object to be up to date once the video has been fully played: frames won't be dropped while the video is paused.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-03-24 05:14:09 PDT
<
rdar://problem/107182984
>
Jean-Yves Avenard [:jya]
Comment 2
2023-03-24 05:25:13 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/11915
EWS
Comment 3
2023-03-24 07:46:16 PDT
Committed
262071@main
(ad2552fcc7cd): <
https://commits.webkit.org/262071@main
> Reviewed commits have been landed. Closing PR #11915 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug